THRIFT-6017: Upgrade jsdoc to 4.x and override transitive dependency …#3608
Open
bigjust wants to merge 1 commit into
Open
THRIFT-6017: Upgrade jsdoc to 4.x and override transitive dependency …#3608bigjust wants to merge 1 commit into
bigjust wants to merge 1 commit into
Conversation
…in lib/js Upgrade jsdoc from ^3.6.7 to ^4.0.0 in lib/js and add an npm override to force grunt-jsdoc to use jsdoc 4.x instead of 3.x. This eliminates taffydb (CVE-2019-10790) from the lib/js dependency tree. lib/ts has no jsdoc dependency on current master, so no change needed there. Client: js Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Generated-by: Claude Sonnet 4.6
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the JavaScript library’s documentation tooling to JSDoc 4.x and uses npm overrides to ensure grunt-jsdoc doesn’t pull in JSDoc 3.x, removing taffydb (CVE-2019-10790) from lib/js’s dependency tree.
Changes:
- Upgrade
jsdocfrom^3.6.7to^4.0.0inlib/js. - Add an npm
overridesentry intended to forcegrunt-jsdocto use JSDoc 4.x. - Refresh
package-lock.jsonto reflect the new resolved dependency graph (including removal oftaffydb).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/js/package.json | Bumps jsdoc to 4.x and adds an npm override to control transitive JSDoc resolution. |
| lib/js/package-lock.json | Updates the lockfile to the new resolved versions, removing taffydb from the tree. |
Files not reviewed (1)
- lib/js/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+30
to
32
| "overrides": { | ||
| "jsdoc": "^4.0.0" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in lib/js
Upgrade jsdoc from ^3.6.7 to ^4.0.0 in lib/js and add an npm override to force grunt-jsdoc to use jsdoc 4.x instead of 3.x. This eliminates taffydb (CVE-2019-10790) from the lib/js dependency tree.
lib/ts has no jsdoc dependency on current master, so no change needed there.
Client: js
Generated-by: Claude Sonnet 4.6
[skip ci]anywhere in the commit message to free up build resources.